-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Clarify Dart getting started steps #2087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix formatting
Looks fine to me -- @athomas @subfuzion any objections/agreement? 😄 |
athomas
reviewed
Nov 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
subfuzion
reviewed
Nov 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
taik0
pushed a commit
to alombarte/docs
that referenced
this pull request
Mar 26, 2025
Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh [nats-streaming] Release v0.23.2 (docker-library#2084) Details can be found [here](https://github.com/nats-io/nats-streaming-server/releases/tag/v0.23.2) Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh mariadb docs update (docker-library#2080) * mariadb: using --port As mentioned in #2708 docs documenting how to change the port, particular for host networking was requested. The example in "configuration without a cnf file section" was already the default anyway (utf8), so this was just replaced. Using MARIADB_ROOT_PASSWORD in the example to move away from MySQL naming (still supported however). Closes: docker-library#2078 * mariadb: added support for .sql.zst in /docker-entrypoint-initdb.d This was added a while ago in MariaDB/mariadb-docker#376 * mariadb: add Mariabackup (and restore) mechanism gosu mysql -> --user mysql suggestion thanks @yosifkit Closes: #MariaDB/mariadb-docker/issues/390 * mariadb: add password reset documentation Closes: #MariaDB/mariadb-docker/issues/365 * mariadb: installing plugins * Update mariadb/content.md Co-authored-by: yosifkit <[email protected]> * Update mariadb/content.md Formatting on INSTALL SONAME Co-authored-by: Tianon Gravi <[email protected]> * Update mariadb/content.md Compressed backup simplier Co-authored-by: Tianon Gravi <[email protected]> * Update mariadb/content.md better use of apt-get arguments Co-authored-by: Tianon Gravi <[email protected]> Co-authored-by: yosifkit <[email protected]> Co-authored-by: Tianon Gravi <[email protected]> Run update.sh Run update.sh Clarify Dart getting started steps (docker-library#2087) Run update.sh Run update.sh Fix typo in the varnish docs Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Fix typo in the varnish docs Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Add rockylinux documentation pending library image addition (docker-library#2047) Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Update Solr's lading page on docker-hub with log4shell info (docker-library#2096) * Update Solr's lading page on docker-hub with log4shell info, and also refresh links, copyright year etc. Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh nginx: removed Amplify notices. Service is in life-support mode since quite some time. Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Re-add rabbitmq docs section for auth env vars (docker-library#2069) Run update.sh Run update.sh Run update.sh Friendica: Update doc Run update.sh Friendica - fix typo Run update.sh Run update.sh Run update.sh Run update.sh Add Haskell ARM64 notes And clarify old dockerfiles are no longer included in the repo. Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh [nats] Release v2.7.0 Details can be found [here](https://github.com/nats-io/nats-server/releases/tag/v2.7.0) Signed-off-by: Ivan Kozlovic <[email protected]> Run update.sh Run update.sh Update community links update monica branch name Update monica/license.md Co-authored-by: Tianon Gravi <[email protected]> Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh [README] Add comment about database host name (docker-library#2098) Update Bonita and Migration Tool versions (docker-library#2039) * Update Bonita and Migration Tool versions * Remove reference to MaxPermSize Co-authored-by: Emmanuel Duchastenier <[email protected]> Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh [nats-streaming] Release v0.24.0 Details can be found [here](https://github.com/nats-io/nats-streaming-server/releases/tag/v0.24.0) Signed-off-by: Ivan Kozlovic <[email protected]> Run update.sh Run update.sh convertigo: change some keywords in description Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Add API-Firewall docs Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Update Go example to use "go.mod" Run update.sh Run update.sh Update api-firewall content.md and logo.svg files (docker-library#2112) Co-authored-by: Nikolay Tkachenko <[email protected]> Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Update docs for registry v2.8.0 release (docker-library#2113) * Update docs for registry v2.8.0 release * leave the reference to Hub in * Put back the maintainers until we move the ownership of the image * Rename Docker Registry to Distribution Registry Run update.sh Update content.md to include public wording for AL 2022 Tech Preview Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh mariadb: stack example to use MARIADB_ROOT_PASSWORD Trying to use MariaDB names more so to highlight distinction from MySQL. mariadb: documentation update This includes the new features in the release https://mariadb.com/kb/en/mariadb-10242-release-notes/#docker-library The Mariabackup example has been modified to use a separate container for better isolation of backup and data. The mariadb-backup restore method includes an example using /docker-entrypoint-initdb.d. Edits thanks Daniel Rudolf and Ian Gilfillan. Run update.sh Run update.sh Run update.sh Run update.sh Haskell - add custom slim section Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Update Ghost example to MySQL 8 Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Update Eggdrop documentation (docker-library#2120) * Add package install directions * change IRC servers Run update.sh Run update.sh Run update.sh Run update.sh Golang 1.18 (docker-library#2123) Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Fixed some capitalization and wording in README.md Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh [varnish] adjust the tmpfs directory for permission reasons Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh [varnish] add a few words about vmods Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Add a new emqx image docs (docker-library#2032) Signed-off-by: zhanghongtong <[email protected]> Run update.sh Run update.sh Run update.sh Add "description cut off" warning at end too This has to be slightly more clever than the warning at the beginning to try and avoid weird markdown rendering (so it looks reasonably clean) but it isn't *too* horrible. Fix minor issues in nextcloud code blocks Adjust a few content oddities Esp. fixing cases of tianon/markdownfmt@91c4530 Run update.sh Run update.sh Run update.sh Run update.sh Update doc for bonita 2022.1 (docker-library#2127) Co-authored-by: Baptiste Mesta <[email protected]> Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh [nats] Release v2.8.0 Details can be found [here](https://github.com/nats-io/nats-server/releases/tag/v2.8.0) Signed-off-by: Ivan Kozlovic <[email protected]> Run update.sh Add deprecation notice to express-gateway Run update.sh Run update.sh update logo for emqx Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Clarify support for non Temurin vulnerabilities Replaced PNG with newer SVG logo and updated README-short.txt (docker-library#2139) Run update.sh Run update.sh Run update.sh Apply fixes from upstream Run update.sh Run update.sh Run update.sh Run update.sh Add more description around OpenJDK to make status more clear Switch to latest YOURLS logo Fix YOURLS GitHub link Run update.sh Run update.sh typo [varnish] document install vmods (docker-library#2134) Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Remove ONBUILD references from Mono content.md The onbuild variant was removed a long time ago, but I wasn't aware of this doc. Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Add "jobber" deprecation notice Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Update POSTGRES_HOST_AUTH_METHOD description Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Update docs for Solr 9.0 (docker-library#2153) Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Add specific Windows note to Docker about the image being client-only Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh chore(mediawiki): add explicit volume definitions Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Update "gcc" license link Closes docker-library#1772 Run update.sh Add a note about mysql_native_password next to our use of it Run update.sh Run update.sh Update Eggdrop docs (docker-library#2160) * Add package install directions * change irc servers * fix formatting * Update server env docs ...and remove old dns module comment * Finish sentence * typo fix Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Screenshot and port updates (docker-library#2163) * Update couchbase screenshots * Update ports * Update ports * Update ports * Remove ports, point at docs * Add current client-node ports * Add client->node ports to run commands Update some external links in the postgres readme (docker-library#2161) * Remove deprecated version element from stack.yml * Update links in content.md * Update version in dockerfile snippet * Revert commit 59a9d9d * Update postgres version in content.md to 14.3 * Use specific commit/version links in content.md * Remove "IPVS connection timeout issue" link Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh eclipse-temurin: update link to slack channel Run update.sh Run update.sh Run update.sh Run update.sh [oraclelinux] update docs to improve the first use experience Because Docker Hub's autogenerated pull command is invalid for this image, I'm trying to make that fact more obvious in the docs. Signed-off-by: Avi Miller <[email protected]> Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Adjust OpenJDK image deprecation notice to fully deprecate (with an exclusion for EA tags) Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Pin MariaDB to 10.5 (fix docker-library#2168) Run update.sh Run update.sh Run update.sh Update rocky linux documentation about latest tag and minimal builds Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Add official image documentation for SATOSA SATOSA is a configurable proxy for translating between different authentication protocols such as SAML2, OpenID Connect, and OAuth2. It implements the Access Protocol Translation layer of [the Authentication and Authorization for Research Collaborations (AARC) Blueprint Architecture](https://aarc-project.eu/architecture/), and it is the foundation of several spoke-hub-style identity federations. Adopters include research institutions, higher education, and governments. Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Map 443/udp to allow HTTP3 Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Add permissions on ci GitHub workflow Upgrade actions/checkout to v3 Update the phpMyAdmin image docs Ref: docker-library/official-images#12931 Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Adjust ghost docs to use "development" mode to use sqlite MySQL is the default db for production mode now; to avoid all the envs for connecting to a mysql instance on every `docker run`, we'll just use dev mode; stack file still has an example of production mode with a MySQL server. Update Ghost documentation with more production mode pointers Run update.sh Run update.sh Adjust debian doc to not reference `jessie` or `stretch` Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Adjust `mongo` shell command to use `mongosh` - `mongo` was removed in 6.0 - `mongosh` is only available in 5+ Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Add support for Launchpad URLs Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh [nats] Release v2.9.0 Details can be found [here](https://github.com/nats-io/nats-server/releases/tag/v2.9.0) Signed-off-by: Ivan Kozlovic <[email protected]> Run update.sh Run update.sh ⬆ update to golang 1.19 Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Update lightstreamer logo (docker-library#2201) eclipse-temurin: update JRE wording in docs Run update.sh Run update.sh Run update.sh Run update.sh Fix container path for cache dir The code block contains the paths that should be mapped, `/var/cache/nginx` and `/var/run` for readonly cases. However, the description immediately above the code block also listed two paths. The first, `/var/cache`, would require additional dirs to already exist within the dir. For example, the application will fail to start if the host didn't create an `nginx` dir prior to starting the container. This change updates the path in the description so it matches the path mapped in the code block and no dirs need to exist before starting the container. Run update.sh Update OpenJDK short description to be more precise added _HASH envs Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh mariadb: MARIADB_ROOT_PASSWORD_HASH to set of manditory vars Order the manditory MARIADB_ROOT_PASSWORD* by decreasing strength. Add ref MARIADB_PASSWORD_HASH to MARIADB_ROOT_PASSWORD_HASH for setting password. mariadb: custom configuration file Many people where custom mounting their configuration on /etc/mysql/my.cnf overriding many other defaults. The docs here simplify to the /etc/mysql/conf.d directory intended. A few people are doing user@hostname configurations and with the way skip-name-resolve is implemented in the server it not obvious how to disable this. Added docs to clarify this, and how to examine the final configuration. mariadb: use mariadb names instead of mysql ones These have existed since 10.4. While 10.3 won't have these, lets account for the common cases. Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Add deprecation notice for CentOS Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Add note that "hello-world" can run as an arbitrary user Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Fix mysql import in nextcloud readme (docker-library#2210) Run update.sh Run update.sh Run update.sh Link to more Stack Exchange sites Also, link directly to their "What topics can I ask about here?" pages instead of to a search. Update Bonita and Migration Tool versions Run update.sh Run update.sh Run update.sh Readme Typo when referring to pre-existing db folder (docker-library#2212) [nats] Release v2.9.3 Details can be found [here](https://github.com/nats-io/nats-server/releases/tag/v2.9.3) Signed-off-by: Ivan Kozlovic <[email protected]> Run update.sh Run update.sh Run update.sh [nats-streaming] Release v0.25.2 Details can be found [here](https://github.com/nats-io/nats-streaming-server/releases/tag/v0.25.2) Signed-off-by: Ivan Kozlovic <[email protected]> Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Update the HAProxy Docs URL see https://www.mail-archive.com/[email protected]/msg42790.html Run update.sh Run update.sh Add Alpine locale information for Postgres 15 (docker-library#2220) Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Update community Slack link Run update.sh Update forwarded ports in example docker run commands (docker-library#2224) * Update ports in example docker run commands Run update.sh Run update.sh Tidy up port list Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh [varnish] add a few words about port variables remove line in jetty docs about JDK9 and HTTP2 (docker-library#2230) Signed-off-by: Lachlan Roberts <[email protected]> Run update.sh ubuntu: Update Git references to Launchpad Ubuntu base images rootfs tarballs are now fetched from Launchpad Git repository. The location https://partner-images.canonical.com/oci/ is no longer used. Update links in the documentation to refer to the https://git.launchpad.net/cloud-images/+oci/ubuntu-base Git repository URL instead. The Launchpad Git repository URL is also set in github-repo file. This shouldn't matter because the fact that an URL is a GitHub URL is used only to fetch badges from open-source CI/CD services, and in case the URL is not a GitHub URL, the HTTP request will just fail, and no badge will be included. Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh Run update.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@athomas can you please review?